Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow suppressing progress dots and outputs #1116

Merged
merged 5 commits into from
Mar 21, 2024

Conversation

mikocot
Copy link
Contributor

@mikocot mikocot commented Mar 8, 2024

Adds support for --suppress-progress and --suppress-outputs parameters of stack up, preview, destroy and refresh.

Requires changes releasesd in the automation api (pulumi/pulumi 3.109 - pulumi/pulumi#15596)

Original issue described here:
fixes #1108

…adme, require recent changes from pulumi automation
@mikocot mikocot mentioned this pull request Mar 8, 2024
@mikocot
Copy link
Contributor Author

mikocot commented Mar 12, 2024

There is another similar PR for additional params: #1116

Seems like a low hanging fruit, any of the repo owners would mind looking into it? I'm not sure why the further tests are not passing.

CC: @Frassle @simenandre @justinvp ?

Copy link
Contributor

@tgummerer tgummerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikocot Sorry for the delay here. I'm not super familiar with how adding arguments works and why the tests are failing, but I'm wondering if these options still need to be added to the action.yml file?

@mikocot
Copy link
Contributor Author

mikocot commented Mar 21, 2024

@tgummerer good point, I've forgotten about that part, looks like that indeed was the problem ;)

Copy link
Contributor

@tgummerer tgummerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for fixing this up!

@tgummerer tgummerer merged commit fcac4d5 into pulumi:master Mar 21, 2024
76 checks passed
@mikocot
Copy link
Contributor Author

mikocot commented Mar 26, 2024

@tgummerer hey, when do you plan the next release? I think the last one was in january?

@tgummerer
Copy link
Contributor

We do releases for the action mostly ad-hoc. I was kind of waiting for #1118 to be ready so we could include that in the release as well. However as that looks like it's probably going to be a major version bump, I don't really see a downside in releasing a minor version now. I'll get on that.

@tgummerer
Copy link
Contributor

@mikocot I just released v5.2.0 with your changes included. Thanks again for your contribution!

@mikocot
Copy link
Contributor Author

mikocot commented Mar 26, 2024

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppress progress dots
2 participants