prepare the changelog for the 6.0.0 release #1278
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a breaking change, so we should release a new major version.
justinvp
requested changes
Sep 9, 2024
There was a problem hiding this comment.
Before we release this, should we address Komal's comment at #1118 (comment)?
Looks like we at least have the refresh option for up and preview in nodejs automation api, but would be great to get this supported for
destroyas well to have consistency across commands.
Otherwise, it looks like if you're running destroy with the refresh option set, we no longer do a refresh at all.
|
😬 I missed that comment, thanks for catching it! Yes we should! |
tgummerer
added a commit
to pulumi/pulumi
that referenced
this pull request
Sep 9, 2024
Currently refresh support is inconsistent in automation API. Go supports it for up, preview and destroy, NodeJS only supports it for up and preview, and Python doesn't support it at all. Support it for all three in up, preview and destroy. The important bit is supporting it for NodeJS (see pulumi/actions#1278 (review)), but it's best to support it consistently when we can.
|
pulumi/pulumi#17209 has the changes. We can merge this after merging and releasing that. |
github-merge-queue bot
pushed a commit
to pulumi/pulumi
that referenced
this pull request
Sep 17, 2024
Currently refresh support is inconsistent in automation API. Go supports it for up, preview and destroy, NodeJS only supports it for up and preview, and Python doesn't support it at all. Support it for all three in up, preview and destroy. The important bit is supporting it for NodeJS (see pulumi/actions#1278 (review)), but it's best to support it consistently when we can.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a breaking change from #1118, so we should release a new major version.