Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Refresh #128

Merged
merged 8 commits into from
Mar 22, 2021
Merged

feat: Refresh #128

merged 8 commits into from
Mar 22, 2021

Conversation

simenandre
Copy link
Contributor

fixes #126

stack72
stack72 reviewed Mar 20, 2021
View reviewed changes
Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs added to the README as well :)

@simenandre simenandre requested a review from stack72 March 21, 2021 15:09
stack72
stack72 approved these changes Mar 22, 2021
View reviewed changes
src/main.ts
const onOutput = (msg: string) => {
core.debug(msg);
core.info(msg);
};

if (config.refresh) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this - separating the refresh out of the log group :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, thanks!

@stack72 stack72 merged commit 65cd0e5 into master Mar 22, 2021
@stack72 stack72 deleted the feat/refresh branch March 22, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stack72 stack72 stack72 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for refresh
2 participants
@simenandre @stack72