-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version and downsert #682
Conversation
Bumps [lint-staged](https://github.com/okonet/lint-staged) from 12.3.8 to 12.4.0. - [Release notes](https://github.com/okonet/lint-staged/releases) - [Commits](lint-staged/lint-staged@v12.3.8...v12.4.0) --- updated-dependencies: - dependency-name: lint-staged dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Hi @Moon1706 Thanks for your contribution. 👏🏻 Also, regarding In the future, would you please submit separate PRs for individual features? It's very unlikely we merge a PR for more than 1 feature at a time. This helps reduce the maintenance burden, helps us to review PRs quickly, and reduces the likelihood of introducing regressions. Thanks again for your active participation in our OSS community. |
@RobbieMcKinstry
To recap, I think the first case is the best, but I opened for another suggestion. |
#681 (comment) |
@RobbieMcKinstry |
Thanks for the suggestion! I haven't seen this package before. I'll take a look. I do agree that the I'll give it some more thought! Maybe it's enough to support only the subcommands users request once they request them, slowing the complexity growth until it's needed. |
@RobbieMcKinstry |
Quick follow up: |
This PR appends 2 additional fields:
version
anddownsert
.The
version
variable allows you to manage the target version of Pulumi. Default value is^3
.In turn,
downsert
variable in combination withdestroy
command removes Pulumi stack. Default value isundefined
.PS: added checking
downsert
in the Promise impossible, because after this we use Stack variable a few times.