Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release changelog is missing #1013

Closed
mikhailshilkov opened this issue Jun 27, 2024 · 2 comments · Fixed by #1016
Closed

Release changelog is missing #1013

mikhailshilkov opened this issue Jun 27, 2024 · 2 comments · Fixed by #1016
Assignees
@danielrbradley
Labels
kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer
Milestone
0.107

Comments

@mikhailshilkov
Copy link
Member

It looks like we stopped producing useful changelogs for releases a couple of weeks ago. Examples:

Most releases' changelog is just one last change (last commit). Instead, they should include all changes.
@mikhailshilkov mikhailshilkov added p1 A bug severe enough to be the next item assigned to an engineer kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Jun 27, 2024
@corymhall
Copy link
Contributor

I manually updated all of the AWS releases that were missing full release notes.

@mjeffryes mjeffryes removed the needs-triage Needs attention from the triage team label Jun 27, 2024
@mjeffryes
Copy link
Member

This is probably caused by using shallow clones of the git repo so goreleaser can't find the previous tag.

@danielrbradley danielrbradley mentioned this issue Jun 28, 2024
Merged
danielrbradley added a commit that referenced this issue Jul 3, 2024
@danielrbradley
Remove goreleaser (#1016)
e869944 
Stop using goreleaser, improve our release notes, speed up releases.

- Fixes #1013
- Closes #816
- Partially addresses #731
- Related to #967

This should also save 3 hours of waiting per release of AWS.

Build cross-platform provider binaries, in parallel, straight after
prerequisites, then only calculate hashes & push to S3 and GitHub
releases directly during the publish job.

Specifics:

- Use GitHub's own release notes generator which allows us to suppliment
with our own context - specifically the schema change since the previous
latest release.
- Capture and restore the `schema-embed.json` to avoid having to run
`tfgen` on every provider build.
- Build the multi-platform build straight into the makefile for easier
local testing.
- Remove clearing disk space during publish as we're not doing any build
work there any more.

This does not include reworking tests to use the the provider binary
being released - but this can be added later fairly easily.
@mjeffryes mjeffryes added this to the 0.107 milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielrbradley danielrbradley

Labels
kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer
Projects
None yet
Milestone
0.107
Development

Successfully merging a pull request may close this issue.

Remove goreleaser pulumi/ci-mgmt
4 participants
@danielrbradley @mjeffryes @mikhailshilkov @corymhall