Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows signing breaks if freeDiskSpaceBeforeBuild: true is set #1215

Closed
blampe opened this issue Dec 12, 2024 · 0 comments · Fixed by #1216
Closed

Windows signing breaks if freeDiskSpaceBeforeBuild: true is set #1215

blampe opened this issue Dec 12, 2024 · 0 comments · Fixed by #1216
Assignees
@blampe
Labels
kind/bug Some behavior is incorrect or out of spec kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed

Comments

@blampe
Copy link
Contributor

blampe commented Dec 12, 2024

The signing step is currently using the runner's baked-in az CLI to login, and the free-disk-space action is cleaning it up.
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Dec 12, 2024
This was referenced Dec 12, 2024
Closed
Merged
@iwahbe iwahbe added kind/bug Some behavior is incorrect or out of spec kind/engineering Work that is not visible to an external user and removed needs-triage Needs attention from the triage team labels Dec 12, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 12, 2024
@blampe
Fix windows signing with freeDiskSpaceBeforeBuild (#1216)
5918ee1 
Fixes #1215.
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blampe blampe

Labels
kind/bug Some behavior is incorrect or out of spec kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix windows signing with freeDiskSpaceBeforeBuild pulumi/ci-mgmt
3 participants
@blampe @iwahbe @pulumi-bot