Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize bridged provider test setup for re-use #752

Closed
thomas11 opened this issue Dec 20, 2023 · 1 comment
Closed

Modularize bridged provider test setup for re-use #752

thomas11 opened this issue Dec 20, 2023 · 1 comment
Assignees
Labels
kind/engineering Work that is not visible to an external user resolution/wont-fix This issue won't be fixed

Comments

@thomas11
Copy link
Contributor

pulumi/pulumi-aws#3074 uses the extension point extraTests in .ci-mgmt.yaml to add additional tests. That works great, but it required copy-pasting ~17 workflow steps verbatim to get everything set up so tests could run (check out repo, install dependencies, etc.). If this standard setup was extracted into one or more actions similar to, e.g., install in azure-native, it could simply be re-used.

@thomas11 thomas11 added the kind/engineering Work that is not visible to an external user label Dec 20, 2023
@blampe blampe added the resolution/wont-fix This issue won't be fixed label Dec 16, 2024
@blampe blampe self-assigned this Dec 16, 2024
@blampe
Copy link
Contributor

blampe commented Dec 16, 2024

We consolidated the test workflow (#1214), which would make it much more straightforward to run some additional steps. However ultimately extraTests has been removed from AWS because all of these workflows were more appropriately formulated as standard unit or integration tests.

The custom workflows were slow, hard to maintain, and introduced subtle bugs.

@blampe blampe closed this as completed Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user resolution/wont-fix This issue won't be fixed
Projects
None yet
Development

No branches or pull requests

2 participants