Consolidate test workflow #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blampe
force-pushed
the
blampe/test-consolidate
branch
from
94f51fa to
ef98e62
Compare
There was a problem hiding this comment.
Very excited to see this go in!
I think it would be worth opening tentative PRs to a few key providers to get feedback before merging this. AWS, Azure and GCP at least. It would be good to prepare the fixes for AWS before merging too so that we're not scrambling to fix things after this merges.
@danielrbradley AWS fixes are in :) Test PRs
|
danielrbradley
approved these changes
Dec 12, 2024
This was referenced Dec 13, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
The `permissions` block in a reusable workflow doesn't grant these permissions. These are more used as an early indication of the permissions required by the reusable workflow. The correct permissions still need to be set on the calling side. See `Reusable workflows` in [this blog article](https://www.kenmuse.com/blog/github-actions-workflow-permissions/). Follow up to #1214. Without setting the `permissions` on the calling side, the reusable workflow will not have the correct permissions. The Pulumiverse runs failed without the required `permissions` block: https://github.com/pulumiverse/pulumi-acme/actions/runs/12365788538 After adding the `permissions` block on the calling side: https://github.com/pulumiverse/pulumi-acme/actions/runs/12369028130 pulumiverse/pulumi-acme#98 For Pulumiverse, this fails because the organization wide workflow settings are configured to `Read repository contents and packages permissions`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-provider/aws/.ci-mgmt.yamlto what's currently checked-in.run-acceptance-testsas the starting point.extraTestsare included in the shared workflow mostly for simplicity. This will break aws because those tests will specifyneeds:that are no longer valid. We can fix that manually or just remove these extra tests (pulumi/pulumi-aws#4910, pulumi/pulumi-aws#4909).No special treatment is given to TestPulumiExamples. We're not using this outside of azure-native, and it should really just be treated like any other integration test #1211. If we don't want these tests to run in certain workflows then we should expose some info to let them
t.Skipthemselves.Fixes #1034