Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate Github Actions workflows for pulumi-acme #98

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

ringods
Copy link
Member

@ringods ringods commented Dec 17, 2024

This pull request was generated automatically by the resync-build workflow in this repository.

Copy link
Contributor

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@ringods ringods force-pushed the chore/resync-12365785744 branch from df34c7b to a14783c Compare December 17, 2024 08:19
@ringods ringods merged commit 12a6232 into main Dec 17, 2024
20 checks passed
@ringods ringods deleted the chore/resync-12365785744 branch December 17, 2024 08:52
github-merge-queue bot pushed a commit to pulumi/ci-mgmt that referenced this pull request Dec 17, 2024
The `permissions` block in a reusable workflow doesn't grant these
permissions. These are more used as an early indication of the
permissions required by the reusable workflow. The correct permissions
still need to be set on the calling side.

See `Reusable workflows` in [this blog
article](https://www.kenmuse.com/blog/github-actions-workflow-permissions/).

Follow up to #1214.

Without setting the `permissions` on the calling side, the reusable
workflow will not have the correct permissions.

The Pulumiverse runs failed without the required `permissions` block:
https://github.com/pulumiverse/pulumi-acme/actions/runs/12365788538
After adding the `permissions` block on the calling side:
https://github.com/pulumiverse/pulumi-acme/actions/runs/12369028130

pulumiverse/pulumi-acme#98

For Pulumiverse, this fails because the organization wide workflow
settings are configured to `Read repository contents and packages
permissions`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants