Remove special-casing for TestPulumiExamples #1211
Labels
kind/engineering
Work that is not visible to an external user
Comments
iwahbe
added
kind/engineering
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 12, 2024
* Updates `test-provider/aws/.ci-mgmt.yaml` to what's currently checked-in. * Consolidates test jobs into a shared workflow using `run-acceptance-tests` as the starting point. `extraTests` are included in the shared workflow mostly for simplicity. This will break aws because those tests will specify `needs:` that are no longer valid. We can fix that manually or just remove these extra tests (pulumi/pulumi-aws#4910, pulumi/pulumi-aws#4909). No special treatment is given to TestPulumiExamples. We're not using this outside of azure-native, and it should really just be treated like any other integration test #1211. If we don't want these tests to run in certain workflows then we should expose some info to let them `t.Skip` themselves. Fixes #1034
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TestPulumiExamplesis an integration test specific to azure-native. It runs tests against the p/examples, which is very cool, but ci-mgmt doesn't need to know anything about it.Additionally, checks for
matrix.testTarget == 'pulumiExamples'are not needed. If a repository needs to consume the examples repo it can include it as a submodule.The text was updated successfully, but these errors were encountered: