Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the GH organization configurable #1056

Merged
merged 4 commits into from
Aug 20, 2024
Merged

Make the GH organization configurable #1056

merged 4 commits into from
Aug 20, 2024

Conversation

ringods
Copy link
Member

@ringods ringods commented Aug 16, 2024

A first small change to the GH workflow generation in an attempt to bring ci-mgmt slowly closer to third party package maintainers.

@ringods ringods requested a review from danielrbradley August 16, 2024 14:14
@ringods ringods changed the title Make the GH organizatioin configurable Make the GH organization configurable Aug 16, 2024
@ringods ringods force-pushed the feature/third-party-support-part-1 branch from f4c7b2c to 7fd727a Compare August 20, 2024 07:44
@danielrbradley danielrbradley requested review from guineveresaenger, iwahbe and a team August 20, 2024 08:37
danielrbradley
danielrbradley approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. Paging the rest of providers for review to get a few more eyes on it. Let's aim to merge tomorrow to give others a chance to look over it too.

iwahbe
iwahbe approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is fine.

Warning

As it stands, I don't think we maintain backwards compatibility guarantees on ci-mgmt. It is very much a "use at your own risk" repository.

provider-ci/internal/pkg/templates/bridged-provider/Makefile Show resolved Hide resolved
@ringods
Copy link
Member Author

ringods commented Aug 20, 2024

I will submit more changes to get thirdparty support in. The only expectation I have is that people are aware of thirdparty support and not deliberately break it or hardcode new stuff to be Pulumi only.

If there is a regression with a third-party provider, I will fast enough find issues and be able to contribute fixes for it.

guineveresaenger
guineveresaenger approved these changes Aug 20, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@ringods @guineveresaenger
Update README.md
dd1f373 
Co-authored-by: Guinevere Saenger <guinevere@pulumi.com>
@ringods ringods merged commit 9b5b5e6 into master Aug 20, 2024
5 checks passed
@ringods ringods deleted the feature/third-party-support-part-1 branch August 20, 2024 17:01
@mjeffryes mjeffryes mentioned this pull request Aug 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwahbe iwahbe iwahbe approved these changes

@guineveresaenger guineveresaenger guineveresaenger approved these changes

@danielrbradley danielrbradley danielrbradley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ringods @danielrbradley @guineveresaenger @iwahbe