Support external bridged provider by reducing Pulumi Corp targeted workflows #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as documented for the `--name` option description
guineveresaenger
approved these changes
Sep 27, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 27, 2024
Continuing on #1084, the name of the template must be populated correctly into the `Makefile` of external bridged providers. I moved `bridged-provider` as the default value into `defaults.config.json` and updated the code generation accordingly.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
I moved `run-acceptance-tests.yml` in #1084 to the `pulumi-provider` folder as I thought it was Pulumi Corp specific. I'm moving this back to `bridged-provider` folder because it is also needed for third-party provider packages. The workflow is updated to use the `GITHUB_TOKEN` with elevated permissions for commenting on the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a set of changes to better support external bridged providers. Such external providers need less of the workflows used by the Pulumi Corp engineering team.
Single set of default configuration values.
The current setup uses a default config file based on the template name:
bridged-providertemplate name maps toprovider-ci/internal/pkg/templates/bridged-provider.config.json. The template name then points to a set of folders containing the actual template files:ci-mgmt/provider-ci/internal/pkg/generate.go
Lines 70 to 72 in 52751c4
These template files use templating based on the configuration options to tweak the generated content for each provider.
If we want to reuse most of these templates for another template name, we must prevent duplicating the config options in a second file. After discussing this with @danielrbradley, the idea was to not have a default config file per template name, but a single default config file applicable to all templates.
Default repository name calculation.
The CLI arguments to
provider-ci generatehas the following currently documented:However, nowhere in the code is a default of "pulumi/pulumi-{config.provider}" calculated. One of the commits in this PR resolves this and improves on it to take the
organizationconfig option into account.By calculating this value based on the
providerandorganizationconfig values, we can runprovider-ci generatenow without the--nameCLI argument. Inmake test-providers, it fixes that theacmeprovider is no longer assumed to be in thepulumiorg, but correctly configured to be in thepulumiverseorganization as specified by its.ci-mgmt.ymlfile.Moved some specific into a Pulumi (Corp) folder
Some of the workflows & issue templates have been moved to a dedicated Pulumi folder. This folder is added to the default
bridged-providertemplate, but not used forexternal-bridged-provider. This reduces the amount and complexity of the workflows for an external provider. An external provider doesn't have a bot running and doesn't require (for now) a few of the repository dispatch scenarios.