Only sign the windows binary when the signing secrets are configured #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With my change, the https://github.com/pulumi/pulumi-xyz/actions/runs/12252090260/job/34178075178?pr=640 |
- Create phony targets for platform-specific provider binaries. - Rename AZURE_SIGNING_CONFIGURED for clarity. - Assert all required fields are set.
danielrbradley
force-pushed
the
only-sign-when-configured
branch
from
3ea528e to
cfe96bc
Compare
danielrbradley
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition of signing Windows binaries unconditionally broke the setup for non-Pulumi managed providers:
#1202 (comment)
This PR checks if the signing secrets have been configured and skips the signing step when not configured, as is currently the case for the providers I manage.
This is tested for the
acmeprovider: