-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding info about Dependency Caching to docs #13265
base: master
Are you sure you want to change the base?
Conversation
Your site preview for commit 1b84c41 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13265-1b84c417.s3-website.us-west-2.amazonaws.com. |
1b84c41
to
6344bcd
Compare
Your site preview for commit 6344bcd is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13265-6344bcda.s3-website.us-west-2.amazonaws.com. |
6344bcd
to
68dd7fe
Compare
Your site preview for commit 68dd7fe is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13265-68dd7fee.s3-website.us-west-2.amazonaws.com. |
68dd7fe
to
c05a82e
Compare
Your site preview for commit c05a82e is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13265-c05a82e4.s3-website.us-west-2.amazonaws.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just nitpicking on grammar mostly :)
@@ -380,6 +381,24 @@ The GitHub block describes settings for Pulumi Deployments' GitHub integration. | |||
} | |||
``` | |||
|
|||
### CacheOptions | |||
|
|||
Cache Options block defines settings related to dependency caching during Deployments. Reading dependencies from cache makes deployments significantly faster. Learn more about dependency caching on the [FAQ page](/docs/pulumi-cloud/deployments/faq/#dependencycaching). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor wording things:
The Cache Options block defines settings related to dependency caching during Deployments. Using dependencies from the cache makes deployments significantly faster.
also the url is missing a hyphen: #dependency-caching
|
||
When using Pulumi-managed deployment agents, you have the option to speed up deployments using Dependency Caching. | ||
|
||
Caching method is simple: during the first deployment, deployment agent will automatically detect downloaded dependencies using lock files, zip them up and store the archive in blob storage. During all consequent deployments, agents will pull such an archive down and unpack it, saving time it would take to redownload those dependencies. When your dependencies change, deployment agents will automatically invalidate an old cache and create a new one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The Caching method"
"the deployment agent"
I think you mean "subsequent" in "During all subsequent deployments"?
"saving time it would normally take..."
"invalidate the old cache" (there should only be one old cache)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Articles kill me every time! The biggest flaw of the English language.
Thank you!
|
||
Caching method is simple: during the first deployment, deployment agent will automatically detect downloaded dependencies using lock files, zip them up and store the archive in blob storage. During all consequent deployments, agents will pull such an archive down and unpack it, saving time it would take to redownload those dependencies. When your dependencies change, deployment agents will automatically invalidate an old cache and create a new one. | ||
|
||
Caches are shared on project level, so all stacks within a project can share the same cache. However, caches are fully isolated and never shared between customers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"the project level"
- `.NET` | ||
- `Python` - ensure that you have `requirements.txt` file in the root of your source code. | ||
- `Go` - ensure that you have `go.mod` and `go.sum` files in the root of your source code. | ||
- `NodeJS` - ensure that you have `packageManager` field specified in `package.json` file. For now, only `npm` and `yarn` are supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ensure that you have the packageManager
field specified in package.json
Dependency Caching is supported for the following runtimes: | ||
|
||
- `.NET` | ||
- `Python` - ensure that you have `requirements.txt` file in the root of your source code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have requirements.txt
file
- `Python` - ensure that you have `requirements.txt` file in the root of your source code. | ||
- `Go` - ensure that you have `go.mod` and `go.sum` files in the root of your source code. | ||
- `NodeJS` - ensure that you have `packageManager` field specified in `package.json` file. For now, only `npm` and `yarn` are supported. | ||
- For `npm`, ensure that you have `package-lock.json` file in the root of your source code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same, you don't need "file"
- `Go` - ensure that you have `go.mod` and `go.sum` files in the root of your source code. | ||
- `NodeJS` - ensure that you have `packageManager` field specified in `package.json` file. For now, only `npm` and `yarn` are supported. | ||
- For `npm`, ensure that you have `package-lock.json` file in the root of your source code. | ||
- For `yarn`, ensure that you have `yarn.lock` file in the root of your source code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
- For `npm`, ensure that you have `package-lock.json` file in the root of your source code. | ||
- For `yarn`, ensure that you have `yarn.lock` file in the root of your source code. | ||
|
||
To confirm Dependency Caching is working and/or to troubleshoot, check out logs of your deployments, specifically `Restore Cache` and `Save Cache` steps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
specifically the
Your site preview for commit b55e8c5 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13265-b55e8c55.s3-website.us-west-2.amazonaws.com. |
Updated according to comments |
b55e8c5
to
bc3fe11
Compare
Your site preview for commit bc3fe11 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13265-bc3fe114.s3-website.us-west-2.amazonaws.com. |
|
||
This option is only available for Pulumi-managed deployment agents. | ||
|
||
* **enable** (boolean): Whether to use Dependency Caching. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's currently enabled
but I can change it to enable
. Do we have a preference? (ref)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should match the API, which is enable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding to the docs! Looks good except for notes about casing style. I would also add, at minimum, some explanation to the .NET
bullet point. Even if it just says ".NET
- no special configuration required"
|
||
Dependency Caching is supported for the following runtimes: | ||
|
||
- `.NET` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have some description, like the other bullet points?
|
||
This option is only available for Pulumi-managed deployment agents. | ||
|
||
* **enable** (boolean): Whether to use Dependency Caching. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link to the new section in FAQ doc.
@@ -380,6 +381,24 @@ The GitHub block describes settings for Pulumi Deployments' GitHub integration. | |||
} | |||
``` | |||
|
|||
### CacheOptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have inconsistent casing and spacing on various terms here. "CacheOptions" vs "Cache Options" vs cacheOptions
vs "cache options"...
For the H3 use sentence casing: "Cache options"
In the paragraph text, don't capitalize (it's not a proper noun): "cache options" or use the specific symbol cacheOptions
, depending on wether you're referring to the concept of cache options or the JSON syntax for it.
In paragraph text "during Deployments" should be "during deployments" (we're talking about the action of deploying, not the product name). Usage of "Dependency Caching" here should also be lower case.
@@ -21,6 +21,25 @@ aliases: | |||
|
|||
Deployments run on single-use virtual machines and compute and storage are never shared across runs. We designed our architecture to maximize isolation. In addition, security features like OIDC allow you to fine tune credential scope, lifetime, and expiration policies at a per-deployment level. It is also possible to use [self-hosted runners](/docs/pulumi-cloud/deployments/customer-managed-agents/) if you require additional isolation. | |||
|
|||
## Dependency Caching |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Title case-> "Dependency Ccaching"
@@ -21,6 +21,25 @@ aliases: | |||
|
|||
Deployments run on single-use virtual machines and compute and storage are never shared across runs. We designed our architecture to maximize isolation. In addition, security features like OIDC allow you to fine tune credential scope, lifetime, and expiration policies at a per-deployment level. It is also possible to use [self-hosted runners](/docs/pulumi-cloud/deployments/customer-managed-agents/) if you require additional isolation. | |||
|
|||
## Dependency Caching | |||
|
|||
When using Pulumi-managed deployment agents, you have the option to speed up deployments using Dependency Caching. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
casing/emphasis: "Dependency Caching"->"dependency caching"
Instead of capitalizing the concept of "Dependency Caching" in the text, use it in lower case. However, the first time you introduce a new concept like this, you can use italics to indicate it is a special concept to understand (instead of proper noun casing).
|
||
Caches are shared on the project level, so all stacks within a project can share the same cache. However, caches are fully isolated and never shared between customers. | ||
|
||
Dependency Caching is supported for the following runtimes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
casing->"Dependency Ccaching"
Updated according to comments, thank you for detailed feedback! |
Your site preview for commit d1d98e2 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13265-d1d98e2a.s3-website.us-west-2.amazonaws.com. |
Proposed changes
Unreleased product version (optional)
Related issues (optional)