Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic when object key not string #406

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Fix panic when object key not string #406

merged 3 commits into from
Oct 18, 2024

Conversation

seanyeh
Copy link
Contributor

@seanyeh seanyeh commented Oct 18, 2024 •
edited
Loading

Fixes #407

Example env def that causes panic:

values:
  a: value
  b: { "${a}": "value" }

@seanyeh seanyeh marked this pull request as ready for review October 18, 2024 23:12
@seanyeh seanyeh requested review from pgavlin and a team October 18, 2024 23:13
@seanyeh seanyeh force-pushed the syeh/fix-panic-object-key-not-string branch from bc69a92 to 852ecdc Compare October 18, 2024 23:14
@seanyeh seanyeh merged commit 1a77db0 into main Oct 18, 2024
6 checks passed
@seanyeh seanyeh deleted the syeh/fix-panic-object-key-not-string branch October 18, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komalali komalali komalali approved these changes

@dschaller dschaller dschaller approved these changes

@pgavlin pgavlin Awaiting requested review from pgavlin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic when object key is not string
3 participants
@seanyeh @dschaller @komalali