[syntax] Refactor YAML editing functionality #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the CLI's `yamlNode` type and methods with equivalents on `syntax.YAMLNode`. This is a bit duplicative of functionality already in the syntax package, which allows consumers to edit syntax trees without knowledge of the concrete syntax. However, this is the lowest-lift option for refactoring this functionality with high confidence in the results. We should replace the `YAMLNode` methods with higher-level methods that are concrete-syntax-agnostic in the future.
pgavlin
added
the
impact/no-changelog-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the CLI's
yamlNodetype and methods with equivalents onsyntax.YAMLNode.This is a bit duplicative of functionality already in the syntax package, which allows consumers to edit syntax trees without knowledge of the concrete syntax. However, this is the lowest-lift option for refactoring this functionality with high confidence in the results. We should replace the
YAMLNodemethods with higher-level methods that are concrete-syntax-agnostic in the future.