Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the examples to use the latest API proposal #441

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Update the examples to use the latest API proposal #441

merged 1 commit into from
Nov 7, 2019

Conversation

justinvp
Copy link
Member

@justinvp justinvp commented Oct 25, 2019 •
edited
Loading

@justinvp justinvp mentioned this pull request Oct 25, 2019
Merged
@justinvp justinvp mentioned this pull request Nov 5, 2019
Closed
@justinvp justinvp marked this pull request as ready for review November 7, 2019 17:27
@justinvp justinvp requested a review from ekrengel November 7, 2019 23:07
ekrengel
ekrengel approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@ekrengel ekrengel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Although my guess is that we dont want examples pointing to dev for too long?

@justinvp
Copy link
Member Author

justinvp commented Nov 7, 2019

Although my guess is that we dont want examples pointing to dev for too long?

Right. We'll change it to an actual version soon once it's been released.

@justinvp justinvp merged commit fa0db85 into master Nov 7, 2019
@pulumi-bot pulumi-bot deleted the justin/policyapi branch November 7, 2019 23:16
dixler pushed a commit that referenced this pull request Jan 21, 2022
@justinvp
Update PaC examples for the changed API (#441)
2b65792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekrengel ekrengel ekrengel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update PaC examples
2 participants
@justinvp @ekrengel