Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #71: Use a specific namespace of current context #74

Merged
merged 2 commits into from
Nov 2, 2020
Merged

fix: #71: Use a specific namespace of current context #74

merged 2 commits into from
Nov 2, 2020

Conversation

hatappi
Copy link
Contributor

@hatappi hatappi commented Sep 22, 2020

I faced the issue below.
#71: Current context not respected

I tried to create a PR to solve this.
Would you please review this PR when you get a chance ?

@hatappi hatappi mentioned this pull request Sep 22, 2020
Open
@lblackstone
Copy link
Member

@hatappi Thanks for the PR, and sorry I missed this earlier. Looks like this will need a rebase/merge to pull in changes from #78

@hatappi
Copy link
Contributor Author

hatappi commented Oct 10, 2020

@lblackstone
Thank you for confirmation of my PR.
I rebased. Could you confirm when you have time?

lblackstone
lblackstone approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@lblackstone lblackstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks for the PR!

@lblackstone lblackstone merged commit 97245c3 into pulumi:master Nov 2, 2020
@hatappi hatappi deleted the fix-71-use-current-context branch November 3, 2020 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lblackstone lblackstone lblackstone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hatappi @lblackstone