Sanitize quotation marks read from CFN files #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikhailshilkov
added
the
impact/no-changelog-required
Does the PR have any schema changes?Looking good! No breaking changes found. |
mikhailshilkov
force-pushed
the
mikhailshilkov/sanitize-quotation-marks
branch
from
3422426 to
1738d67
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1399 +/- ##
==========================================
+ Coverage 23.39% 23.42% +0.03%
==========================================
Files 25 25
Lines 4236 4239 +3
==========================================
+ Hits 991 993 +2
- Misses 3082 3083 +1
Partials 163 163 ☔ View full report in Codecov by Sentry. |
danielrbradley
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace unicode quotation marks U+201C and U+201D “” that we read from cloudformation files with canonical ones to avoid rendering issues in the docs.
Fix #1343