Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Client abstraction #1416

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Add a Client abstraction #1416

merged 2 commits into from
Mar 14, 2024

Conversation

mikhailshilkov
Copy link
Member

@mikhailshilkov mikhailshilkov commented Mar 14, 2024

Adds another client layer around Cloud Control operations to encapsulate serialization, error handling, and awaiting long-running operations.

No functional changes.

@mikhailshilkov mikhailshilkov added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Mar 14, 2024
Copy link
Contributor

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 32.85714% with 47 lines in your changes are missing coverage. Please review.

Project coverage is 23.80%. Comparing base (28f60c2) to head (968e815).
Report is 2 commits behind head on master.

Files Patch % Lines
provider/pkg/provider/client/client.go 31.57% 32 Missing and 7 partials ⚠️
provider/pkg/provider/provider.go 38.46% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1416      +/-   ##
==========================================
+ Coverage   23.76%   23.80%   +0.04%     
==========================================
  Files          27       28       +1     
  Lines        4237     4259      +22     
==========================================
+ Hits         1007     1014       +7     
- Misses       3064     3077      +13     
- Partials      166      168       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shape of the client looks good. Just a question on how we're handling the partial create case.

provider/pkg/provider/client/client.go Show resolved Hide resolved
provider/pkg/provider/provider.go Outdated Show resolved Hide resolved
Copy link
Contributor

@thomas11 thomas11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

provider/pkg/provider/client/client.go Outdated Show resolved Hide resolved
@mikhailshilkov mikhailshilkov marked this pull request as ready for review March 14, 2024 18:05
@mikhailshilkov mikhailshilkov merged commit 6c27c27 into master Mar 14, 2024
17 checks passed
@mikhailshilkov mikhailshilkov deleted the mikhailshilkov/client branch March 14, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants