-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Client abstraction #1416
Add a Client abstraction #1416
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1416 +/- ##
==========================================
+ Coverage 23.76% 23.80% +0.04%
==========================================
Files 27 28 +1
Lines 4237 4259 +22
==========================================
+ Hits 1007 1014 +7
- Misses 3064 3077 +13
- Partials 166 168 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The shape of the client looks good. Just a question on how we're handling the partial create case.
efae159
to
eef16d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Adds another client layer around Cloud Control operations to encapsulate serialization, error handling, and awaiting long-running operations.
No functional changes.