Don't send writeOnly properties if they're also createOnly

[danielrbradley]

Fixes #1435

Ideally we'd have an integration test around this case to avoid future regression but currently the VPC-based test is very unstable, so has been disabled, but included for documentation of the issues.

• Deletion of the aws-native:ec2:IpamPoolCidr regularly fails with "GeneralServiceException": Error occurred during operation 'The CIDR has one or more allocations.' even after the VPC is deleted for serveral minutes.
• Sometimes Update of the aws-native:ec2:IpamPool fails with "NotStabilized": IpamPoolCidrFailureReason(Message=The CIDR has one or more allocations.
• The refresh of the aws-native:ec2:IpamPool fails due to a diff in the provisionedCidrs property.
• It's also not ideal that we have to create the IPAM manually to avoid the test failing if run in parallel as only 1 IPAM is allowed to be created in each region.

Extracted the patch generation code instead and wrote a unit around it. Also replicated the fix into the untyped ExtensionResource implementation and tested using the same test suite.

[github-actions]

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

[codecov]

Codecov Report

Attention: Patch coverage is 40.00000% with 66 lines in your changes are missing coverage. Please review.

Project coverage is 24.60%. Comparing base (64dbca9) to head (64e78dc).
Report is 1 commits behind head on master.

Files	Patch %	Lines
provider/pkg/resources/extension_resource.go	0.00%	58 Missing ⚠️
provider/pkg/resources/patching.go	84.44%	4 Missing and 3 partials ⚠️
provider/pkg/provider/provider.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1448      +/-   ##
==========================================
+ Coverage   23.72%   24.60%   +0.87%     
==========================================
  Files          31       32       +1     
  Lines        4446     4475      +29     
==========================================
+ Hits         1055     1101      +46     
+ Misses       3227     3208      -19     
- Partials      164      166       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mikhailshilkov]

Code change makes sense to me, but I’m missing a unit test with it

[mjeffryes]

I like that you were able to bring the patch logic for extension and other resources together with this change.

I did have on significant concern about the introduction of a createOnly property on the ExtensionResource, but otherwise just a few nits.

[arianvp]

Deletion of the aws-native:ec2:IpamPoolCidr regularly fails with "GeneralServiceException": Error occurred during operation 'The CIDR has one or more allocations.' even after the VPC is deleted for serveral minutes.

Yeh it takes very long for the IpamPoolCidr to be released back into the pool unfortunately :( I guess this is something for Amazon to fix