Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete artifact-cleanup.yml #1466

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Apr 1, 2024

The action being called is no longer supported, and fails generating P1s for the team.

Despite the file claiming it is auto-generated, the file is not present in ci-mgmt.

Recent versions of GitHub actions automatically expire artifacts after 90 days.

This setting is configurable, so if a more frequent interval is ever needed we can configure the artifact uploading jobs with an appropriate setting.

In the meanwhile removing this workflow stops the P1s.

Fixes #1464
Fixes #1455

The action being called is no longer supported, and fails generating P1s for the team.

Despite the file claiming it is auto-generated, the file is not present in ci-mgmt.

Recent versions of GitHub actions automatically expire artifacts after 90 days.

This setting is configurable, so if a more frequent interval is ever needed we can configure the artifact uploading jobs
with an appropriate setting.

In the meanwhile removing this workflow stops the P1s.
@t0yv0 t0yv0 added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Apr 1, 2024
@t0yv0 t0yv0 self-assigned this Apr 1, 2024
Copy link
Contributor

github-actions bot commented Apr 1, 2024

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.29%. Comparing base (7a8152a) to head (c7fb242).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1466   +/-   ##
=======================================
  Coverage   25.29%   25.29%           
=======================================
  Files          34       34           
  Lines        4502     4502           
=======================================
  Hits         1139     1139           
  Misses       3195     3195           
  Partials      168      168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mjeffryes mjeffryes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating this!

@t0yv0 t0yv0 merged commit 1435935 into master Apr 1, 2024
17 checks passed
@t0yv0 t0yv0 deleted the t0yv0/remove-artifact-cleanup branch April 1, 2024 19:47
@t0yv0 t0yv0 added this to the 0.103 milestone Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow failure: cleanup Remove gha-remove-artifacts
2 participants