Deterministically sort default tags to prevent permadiff #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the default tags where randomly appended to the tag list because of Go's random iteration order for maps. This introduces sorting for the key's of the default tags in order to produce deterministic tag lists and prevent permadiffs
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1571 +/- ##
==========================================
+ Coverage 41.62% 41.67% +0.04%
==========================================
Files 35 35
Lines 4685 4689 +4
==========================================
+ Hits 1950 1954 +4
Misses 2533 2533
Partials 202 202 ☔ View full report in Codecov by Sentry. |
t0yv0
reviewed
Jun 5, 2024
| for k := range defaultTags { | ||
| keys = append(keys, k) | ||
| } | ||
| sort.Strings(keys) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the default tags where randomly appended to the tag list because of Go's random iteration order for maps. This introduces sorting for the key's of the default tags in order to produce deterministic tag lists and prevent permadiffs.
Fixes #1486