Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable preview for create and update #1891

Merged
merged 9 commits into from
Dec 12, 2024

additionalProperties will not have readOnly

784e3ad
Select commit
Loading
Failed to load commit list.
Merged

Enable preview for create and update #1891

additionalProperties will not have readOnly
784e3ad
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 11, 2024 in 0s

50.37% (+1.00%) compared to 7ca5a58

View this Pull Request on Codecov

50.37% (+1.00%) compared to 7ca5a58

Details

Codecov Report

Attention: Patch coverage is 87.63441% with 23 lines in your changes missing coverage. Please review.

Project coverage is 50.37%. Comparing base (7ca5a58) to head (784e3ad).

Files with missing lines Patch % Lines
provider/pkg/provider/provider.go 71.42% 8 Missing and 4 partials ⚠️
provider/pkg/resources/cfn_custom_resource.go 0.00% 4 Missing ⚠️
provider/pkg/resources/extension_resource.go 0.00% 4 Missing ⚠️
provider/pkg/outputs/previewOutputs.go 97.61% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1891      +/-   ##
==========================================
+ Coverage   49.36%   50.37%   +1.00%     
==========================================
  Files          47       48       +1     
  Lines        6814     6998     +184     
==========================================
+ Hits         3364     3525     +161     
- Misses       3206     3224      +18     
- Partials      244      249       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov