Fix refresh does not show changes #1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes an issue where the `Read` method was returning the previous (oldState) inputs which meant that refresh operations never showed any changes. There were a couple of other minor changes that this also fixes 1. `customResources` were not returning the correct inputs either 2. The newInputs was incorrectly including the `__inputs` property from the oldState fixes #1796
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1893 +/- ##
=======================================
Coverage 49.29% 49.29%
=======================================
Files 46 46
Lines 6804 6804
=======================================
Hits 3354 3354
Misses 3206 3206
Partials 244 244 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
Readmethod was returning theprevious (oldState) inputs which meant that refresh operations never
showed any changes.
fixes #1796