Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin dependency @pulumi/pulumi to 3.143.0 #1916

Closed
wants to merge 1 commit into from

Conversation

pulumi-renovate[bot]
Copy link
Contributor

@pulumi-renovate pulumi-renovate bot commented Dec 16, 2024

This PR contains the following updates:

Package Type Update Change
@pulumi/pulumi (source) dependencies pin ^3.142.0 -> 3.143.0

Add the preset :preserveSemverRanges to your config if you don't want to pin your dependencies.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - "every weekday" (UTC).

🚦 Automerge: Disabled because a matching PR was automerged previously.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@pulumi-renovate pulumi-renovate bot added dependencies Pull requests that update a dependency file impact/no-changelog-required This issue doesn't require a CHANGELOG update labels Dec 16, 2024
Copy link
Contributor

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.35%. Comparing base (601e792) to head (4532ad9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1916   +/-   ##
=======================================
  Coverage   50.35%   50.35%           
=======================================
  Files          48       48           
  Lines        7000     7000           
=======================================
  Hits         3525     3525           
  Misses       3226     3226           
  Partials      249      249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t0yv0
Copy link
Member

t0yv0 commented Dec 16, 2024

I believe this will start fighting pulumi gen-sdk in this target that is currently what is emitting the reference:

.pulumi/bin/pulumi package gen-sdk provider/cmd/pulumi-resource-aws-native/schema.json --language nodejs --version "$(VERSION_GENERIC)"

@t0yv0
Copy link
Member

t0yv0 commented Dec 16, 2024

Also more generally, shouldn't node SDK retain unpinned dependencies to the Pulumi Node SDK so that user programs could have different versions of Pulumi SDK?

@t0yv0
Copy link
Member

t0yv0 commented Dec 16, 2024

@blampe appreciate a quick pointer where I should go to ask Renovate not to do this.

@blampe
Copy link
Contributor

blampe commented Dec 16, 2024

@t0yv0 it would make sense IMO to disable Renovate on the ./sdk directory. https://github.com/pulumi/renovate-config/pull/11

I think pu/pu is the only other repo with a ./sdk that's meaningful; we're not Renovating it (yet) and if we do we can opt-in that directory.

Also more generally, shouldn't node SDK retain unpinned dependencies to the Pulumi Node SDK so that user programs could have different versions of Pulumi SDK?

Yes, and I'm not sure why it's pinning it here. We use config:best-practices as our base which includes :pinDevDependencies, but that should only touch devDependencies and not dependencies...

@t0yv0
Copy link
Member

t0yv0 commented Dec 16, 2024

Thanks!

@t0yv0 t0yv0 closed this Dec 16, 2024
@pulumi-renovate
Copy link
Contributor Author

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (3.143.0). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@pulumi-renovate pulumi-renovate bot deleted the renovate/pulumi branch December 16, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants