PATCH 0019-Change-default-descriptions-to-Managed-by-Pulumi.patch #2746
Labels
area/patch
An issue describing an existing patch on upstream and the criteria to close it.
kind/engineering
Work that is not visible to an external user
Comments
|
Claims to only edit docs but adds a new resource not present upstream, why? |
t0yv0
added
area/patch
t0yv0
changed the title
|
Looking at this again as part of #4102 It looks like some added resources in this patch may be dead code. The docs editing bit can likely be moved to a quick Go code pass so as not to cause conflicts as a patch. CC @flostadler I'll have a quick look if I can remove this. |
Merged
t0yv0
added a commit
that referenced
this issue
Aug 21, 2024
Upgrade upstream to [5.63.0](https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.63.0) Fixes #4373 Fixes #4372 Fixes #3713 Fixes #4369 There are some changes to patches: - #4369 is removed as it is part of upstream now - #3713 is removed as there was no clean conflict resolution; this patch is under test so if test suite passes the removal is safe - #2746 patch is edited to remove rds/security_group resource code that got removed upstream but was preserved in patches. This code appears to be dead / unused code but continues to generate conflicts - added a patch for gamelift.Matchmaking* resources; these are [deprecated](#4375) but remain supported until the next major release. Upstream moved gamelift to Go SDK v2 so the patch is needed to preserve the Go SDK v1 code for these resources without re-coding them. - added a patch to fix tags for new PF-based resources; this can go away once we land #4151 --------- Co-authored-by: Florian Stadler <florian@pulumi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tracking context on upstream patch 0022-Change-default-descriptions-to-Managed-by-Pulumi.patch here.
The text was updated successfully, but these errors were encountered: