Extend ecs.TaskDefinition containerDefinitions normalization #4126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
containerDefinitions expects a raw JSON which may lead to spurious diff on insignificant changes. The was pre-existing code for normalizing environment variable order and default values. This code is patched to extend it to handle normalizing the default value of healthCheck.timeout=5.
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
flostadler
approved these changes
Jun 28, 2024
…sion or magic string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1738
Fixes #1985
containerDefinitions expects a raw JSON which may lead to spurious diff on insignificant changes. The was pre-existing code for normalizing environment variable order and default values. This code is patched to extend it to handle normalizing the default value of healthCheck.timeout=5.