Upgrade terraform-provider-aws to v5.79.0 #4876
Conversation
| + Read: resourceBucketLegacyRead, | ||
| + Update: resourceBucketLegacyUpdate, | ||
| + Delete: resourceBucketLegacyDelete, | ||
| + CreateContext: resourceBucketLegacyCreate, |
There was a problem hiding this comment.
Was this fairly mechanical or needs careful review?
There was a problem hiding this comment.
Mostly mechanical. AWSClient.Region and AWSClient.Partition are methods now
output.txt
Outdated
| @@ -0,0 +1,28 @@ | |||
| (cd provider && go build -p 2 -o /Users/flo/development/pulumi-aws/bin/pulumi-tfgen-aws -ldflags "-X github.com/pulumi/pulumi-aws/provider/v6/pkg/version.Version=6.0.0-alpha.0+dev -X github.com/hashicorp/terraform-provider-aws/version.ProviderVersion=6.0.0-alpha.0+dev " github.com/pulumi/pulumi-aws/provider/v6/cmd/pulumi-tfgen-aws) | |||
There was a problem hiding this comment.
This file should not be checked in possibly?
There was a problem hiding this comment.
Argh, I hate that upgrade-provider picks up random files.
|
|
||
| // Object lock not supported in all partitions (extra guard, also guards in read func) | ||
| if err != nil && (meta.(*conns.AWSClient).Partition == endpoints.AwsPartitionID || meta.(*conns.AWSClient).Partition == endpoints.AwsUsGovPartitionID) { | ||
| if err != nil && (meta.(*conns.AWSClient).Partition(ctx) == endpoints.AwsPartitionID || meta.(*conns.AWSClient).Partition(ctx) == endpoints.AwsUsGovPartitionID) { |
| @@ -1095,7 +1091,6 @@ def __init__(__self__, *, | |||
| :param pulumi.Input[str] preferred_maintenance_window: Weekly time range during which system maintenance can occur, in (UTC) e.g., `wed:04:00-wed:04:30` | |||
| :param pulumi.Input[str] reader_endpoint: Read-only endpoint for the Aurora cluster, automatically | |||
| load-balanced across replicas | |||
| :param pulumi.Input[str] replication_source_identifier: ARN of a source DB cluster or DB instance if this DB cluster is to be created as a Read Replica. If DB Cluster is part of a Global Cluster, use the `lifecycle` configuration block `ignore_changes` argument to prevent this provider from showing differences for this argument instead of configuring this value. | |||
There was a problem hiding this comment.
Curious why the docstring is lost here?
There was a problem hiding this comment.
It's because replication_source_identifier needs a replacement, they changed the docstring to include the word Terraform. Good thing is the unit tests catch this now after some changes earlier this year :)
Does the PR have any schema changes?Found 1 breaking change: Types
New resources:
Maintainer note: consult the runbook for dealing with any breaking changes. |
flostadler
added
the
needs-release/minor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4876 +/- ##
==============================
==============================
☔ View full report in Codecov by Sentry. |
|
This PR has been shipped in release v6.63.0. |
github-actions
bot
removed
the
needs-release/minor
This PR was generated via
$ upgrade-provider pulumi/pulumi-aws --kind=provider --target-version=5.79.0.Fixes #4873
Fixes #4878