Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in SubnetSpecs Docs #1423

Closed
jdh313 opened this issue Sep 9, 2024 · 2 comments · Fixed by #1425
Closed

Typo in SubnetSpecs Docs #1423

jdh313 opened this issue Sep 9, 2024 · 2 comments · Fixed by #1425
Assignees
@flostadler
Labels
area/docs Improvements or additions to documentation kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@jdh313
Copy link

jdh313 commented Sep 9, 2024

File: themes/default/content/registry/packages/awsx/api-docs/ec2/vpc/_index.md

Private subnets are allocated CIDR block ranges first, followed by Private subnets, and Isolated subnets are allocated last.

The above quoted section lists private subnets as being allocated CIDR blocks twice.
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Sep 9, 2024
@interurban
Copy link

Thanks @jdh313 !

@interurban interurban added kind/bug Some behavior is incorrect or out of spec and removed needs-triage Needs attention from the triage team labels Sep 25, 2024
@interurban interurban modified the milestones: 0.110, 0.111 Sep 25, 2024
@interurban interurban modified the milestones: 0.111, 0.112 Oct 30, 2024
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Nov 12, 2024
@iwahbe iwahbe transferred this issue from pulumi/registry Nov 12, 2024
@flostadler flostadler mentioned this issue Nov 13, 2024
Merged
@flostadler flostadler added area/docs Improvements or additions to documentation and removed needs-triage Needs attention from the triage team labels Nov 13, 2024
@flostadler flostadler self-assigned this Nov 13, 2024
@flostadler flostadler removed this from the 0.112 milestone Nov 13, 2024
flostadler added a commit that referenced this issue Nov 13, 2024
@flostadler
Fix docs of VPC SubnetSpecs (#1425)
8fe29ce 
- **Fix docs of VPC SubnetSpecs**
- **Regenerate schema**
- **Regenerate SDK**

Fixes #1423
@github-project-automation github-project-automation bot moved this from 🧳 Backlog to 🏁 Done in Docs 📚 Nov 13, 2024
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Nov 13, 2024
@pulumi-bot
Copy link
Contributor

This issue has been addressed in PR #1425 and shipped in release v2.18.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flostadler flostadler

Labels
area/docs Improvements or additions to documentation kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
Docs 📚
Status: 🏁 Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix docs of VPC SubnetSpecs pulumi/pulumi-awsx
4 participants
@interurban @flostadler @jdh313 @pulumi-bot