Pre-test pulumi/ci-mgmt#1196 #1589
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
github-merge-queue bot
pushed a commit
to pulumi/ci-mgmt
that referenced
this pull request
Dec 3, 2024
Fixes #967 Fixes #1033 Unlike the ticket spec in #967 , only linux-amd64 binary is tested by the full set of integration tests. We might consider opening a follow up to smoke-test every single one of the platform builds, or else keep #967 open. As to the ticket spec in #1033 the dependency from build_provider to prerequisites is real because prerequisites builds the schema and the schema is needed in the binaries. This needs to stay. Test run: pulumi/pulumi-azuread#1589 Additional exploration: in prerequisites we run `make test_provider` which seems to try running unit tests in the `./provider` directory. Unfortunately some tests in `./provider` directory are also integration tests, e.g. in pulumi-aws and pulumi-azuread, and the convention of passing `go test -short` to only run the unit tests does not seem to be observed universally. For this reason removing `make provider` from prerequisites is not yet possible as it breaks our builds. This is likely out of scope of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.