Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubernetes to pulumiverse #252

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Conversation

brandonpollack23
Copy link
Contributor

@brandonpollack23 brandonpollack23 commented Dec 12, 2024

We have a kubernetes provider so we need to add it to our list in the converter of things not to bridge to terraform. As of now we'll end up with a terraform provider for k8s instead of using our native one.

This will fix that.

@brandonpollack23 brandonpollack23 requested a review from a team as a code owner December 12, 2024 05:20
@brandonpollack23 brandonpollack23 added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Dec 12, 2024
@tgummerer
Copy link
Contributor

This PR could benefit from a description describing why this is being done.

@Frassle Frassle changed the title add kubernetes to pulumiverse Add kubernetes to pulumiverse Dec 12, 2024
Copy link
Contributor

@tgummerer tgummerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the description!

This test is failing presubmit in master, but I believe it may pass
once pulumi/pulumi has convert fixed.

In any case C# does not work here even without strict in master, will
followup and assign a bug shortly.
@brandonpollack23 brandonpollack23 merged commit aa4e95e into main Dec 19, 2024
5 checks passed
@brandonpollack23 brandonpollack23 deleted the bpollack/add_kubernetes branch December 19, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants