Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA caching is untested #82

Open
blampe opened this issue May 29, 2024 · 1 comment
Open

GHA caching is untested #82

blampe opened this issue May 29, 2024 · 1 comment
Labels
awaiting-upstream Awaiting upstream dependency kind/enhancement Improvements or new features

Comments

@blampe
Copy link
Contributor

blampe commented May 29, 2024

We currently skip the GHA caching test because we don't have the necessary environment variables exposed to our job.

Our GitHub workflows are managed by http://github.com/pulumi/ci-mgmt which doesn't currently allow us to add prerequisite steps like crazy-max/ghaction-github-runtime.

@blampe blampe added blocked kind/enhancement Improvements or new features labels May 29, 2024
blampe added a commit that referenced this issue May 29, 2024
Our docs and default value for the GitHub action cache URL were
referring to the
[wrong](https://github.com/tonistiigi/go-actions-cache/blob/master/api.md)
environment variable.

I was under the impression that the underlying library ends up checking
for the correct variable later so this would be only cosmetic, but a
user
[confirmed](#77 (comment))
this does appear to break things.

I brought over an old test I had written while this was still in the
pulumi-docker repo, but unfortunately it doesn't currently test GHA due
to ci-mgmt limitations
#82.

Fixes #77.
@mikhailshilkov mikhailshilkov added awaiting-upstream Awaiting upstream dependency and removed blocked labels Jun 10, 2024
@blampe
Copy link
Contributor Author

blampe commented Aug 8, 2024

This could also be fixed upstream actions/runner#3390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-upstream Awaiting upstream dependency kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants