Update pulumi dockerfile to multiarch #274
Conversation
There was a problem hiding this comment.
Thanks! I do think this would be really useful to have. I left a few comments inline. Would you be willing to update the build matrix as well?
@julienp is the expert on these docker files, so I would want him to have a look at this as well (he's on PTO, and will be back next week)
- Switched the conditionals to default to amd64 - Added a link to docs on built in build args as well as inform the potential values - Added build matrix for creating the multiarch images
|
I believe I addressed all of the comments. Looking at the addition of nonroot, I think all is well there as well. |
|
This looks great! I think we also need to matrix the arch in Annoyingly, there's also |
|
BTW regarding the build failure, seems like a transient GH issue https://github.com/orgs/community/discussions/139743 |
|
Added the code for gcp and aws. Didn't touch the ci one since it looks like all the other ones just use the amd64 version for testing. |
I think we do test the language specific images on arm64, but I'll create a separate issue for myself to look into this for the kitchen sink image. There will likely be some issues due to us using qemu to test arm64, I know at lest dotnet can't run under qemu, and there might be some issues with nodejs also. |
|
Test failure on this PR are because we aren't setup well for running tests for external contributions. I ran the code changes on this branch here https://github.com/pulumi/pulumi-docker-containers/actions/runs/11035725145/job/30690370889?pr=285 |
|
Unfortunately we had to disable the release builds of these images on arm64, because it takes too long to install the Python versions provided by the image when running in Docker + QEMU. Tracking re-enabling these here #297 In the meantime, the images can be built locally on an arm64 machine. |
|
Alright, looks like they plan on opening it up to open source by EOY. I went ahead and built the images and pushed them to my ECR so I can get my internal devs the ability to use devcontainers. I'll keep my eye on that #297 |
I would like to setup devcontainers for use by the developers when they are working on my custom provider. Currently since there isn't an arm64 version, the experience is slow and painful on Apple Silicon. This change updates the Dockerfile so that all that is needed is the
--platform=linux/arm64in the build and it will take care of switching out all the places needed to build. Note: The build matrices will need to be updated if this is something you would consider adding.Thanks.