Run tests in parallel #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienp
added
the
impact/no-changelog-required
julienp
force-pushed
the
julienp/parallel
branch
5 times, most recently
from
edfc757 to
0f6cedc
Compare
tgummerer
approved these changes
Jan 21, 2025
| @@ -107,9 +107,6 @@ func TestPulumiTemplateTests(t *testing.T) { | |||
| for _, test := range testCases { | |||
| test := test | |||
| t.Run(test.template, func(t *testing.T) { | |||
| // TODO: Not running these in parallel to help with disk space. | |||
| // https://github.com/pulumi/pulumi-docker-containers/issues/215 | |||
| // t.Parallel() | |||
There was a problem hiding this comment.
We're removing the TODO here, but not enabling running in parallel 🤔 was this an oversight or intentional?
There was a problem hiding this comment.
Hmmm a little weird, we use program test below, which calls t.Parallel().
I updated this now so that we call t.Parallel() ourselves, and tell program test not to. This way the pulumi new command should be part of the parallel execution too.
There was a problem hiding this comment.
Ah I had missed that. ProgramTest calling parallel itself always trips me up.
julienp
force-pushed
the
julienp/parallel
branch
from
0f6cedc to
219e3f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't gain us that much, the slowest image, provider-build-environment, seems to go from 38 to 35 minutes.