[WIP] ci-mgmt onboarding #1474
Open
[WIP] ci-mgmt onboarding #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
This reverts commit a43ddb6.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
AWS_PROFILE has less precedence than ambient credentials: Credentials from environment variables have precedence over credentials from the shared credentials and AWS CLI config file. Credentials specified in the shared credentials file have precedence over credentials in the AWS CLI config file. If AWS_PROFILE environment variable is set and the AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY environment variables are set, then the credentials provided by AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY will override the credentials located in the profile provided by AWS_PROFILE. https://docs.aws.amazon.com/cli/latest/topic/config-vars.html#id1
blampe
added a commit
that referenced
this pull request
Nov 14, 2024
This consolidates integration tests (currently located in `./examples` and `./provider`) under `./tests`. This is prep work for #1474, and the net result is a clearer distinction between "fast" and "slow" tests meant to be run during the "prerequisites" and "tests" steps in CI. Everything under `./provider` can be considered "fast" and everything under `./tests` can be considered "slow" and worthy of sharding. Specifically: * Everything under `./examples/tests` is moved to `./tests/testdata/programs` as these were assumed to not be user-facing. * Upgrade tests under `./provider` are also moved to `./tests` but tagged in a way that they continue to run as their own job. (These are the new `upgrade_test.go` and `validation_test.go` files.) * `examples/utils/utils.go` moves to `tests/internal/utils`. * `TestEksAuthModeUpgrade` wasn't re-enabled as part of #1387, so I re-enabled and re-recorded it. * `go.mod` is consolidated at the repo root to keep dependencies consistent across the provider and tests. (There are a ton of additional DX advantages to structuring things this way.) This project is not meant to be consumed as a library so this is an acceptable breaking change.
blampe
force-pushed
the
blampe/ci-mgmt
branch
from
697fc8f
to
3f0ba46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Template drops the following options because they can be overridden by makefile targets:
Example tests are all sharded together without language distinction.
To do: