Use provider dependencies in schema #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
corymhall
approved these changes
Nov 13, 2024
flostadler
force-pushed
the
flostadler/auto-reference-provider-version
branch
from
121242d to
28f1a7c
Compare
|
This PR has been shipped in release v3.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the schema generation to read provider dependency versions (AWS & Kube) from the
package.jsonfile (like in awsx).This is the first step towards automating provider dependency upgrades.
To achieve the correct behavior, provider dependencies now need to use a fixed version instead of a semver range. I used the current versions form the lock file, except for the aws provider. Versions 6.42 - 6.46 of the aws provider are not present on mavencentral. To keep the diff of this PR as small as possible, I upgraded aws to the next possible version (
6.47.0).I'll update all provider versions to latest in a separate PR.