chore: Remove gotestfmt from CI #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead use standard go test logging without -v and -json options. This should help reduce confusion as to which test is failing and which log belongs to which test. Follows: pulumi/pulumi-gcp#2712 Re: #1527
Does the PR have any schema changes?Looking good! No breaking changes found. |
blampe
approved these changes
Dec 16, 2024
|
Looks like there's still a little bit of references to it in ci-mgmt: LMK if I can help rip out. |
|
@t0yv0 the upgrade tests are still referencing gotestfmt and failing due to that |
|
Looking. Sorry about that. Do they only run on PRs and not on master? |
t0yv0
added a commit
that referenced
this pull request
Dec 17, 2024
Continuing with #1529 this removes the last remaining references to `gotestfmt` from the codebase.
t0yv0
added a commit
that referenced
this pull request
Dec 17, 2024
Continuing with #1529 this removes the last remaining references to `gotestfmt` from the codebase.
|
This PR has been shipped in release v3.6.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead use standard go test logging without -v and -json options. This should help reduce confusion as to which test is failing and which log belongs to which test.
Follows: pulumi/pulumi-gcp#2712
Re: #1527