Accept renovate suggestions #1541

t0yv0 · 2024-12-18T20:24:54Z

This change accepts suggestions from #1540 and has two things done on top:

update Go test code to the newest version of providertest

Let us see if the build and test passes.

github-actions · 2024-12-18T20:26:56Z

Does the PR have any schema changes?

Found 60 breaking changes:

Resources

"eks:index:Cluster":
- inputs:
  - 🟡 "clusterSecurityGroup" type changed from "/aws/v6.65.0/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup" to "/aws/v6.66.1/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup"
  - 🟡 "instanceRole" type changed from "/aws/v6.65.0/schema.json#/resources/aws:iam%2Frole:Role" to "/aws/v6.66.1/schema.json#/resources/aws:iam%2Frole:Role"
  - 🟡 "instanceRoles": items type changed from "/aws/v6.65.0/schema.json#/resources/aws:iam%2Frole:Role" to "/aws/v6.66.1/schema.json#/resources/aws:iam%2Frole:Role"
  - 🟡 "serviceRole" type changed from "/aws/v6.65.0/schema.json#/resources/aws:iam%2Frole:Role" to "/aws/v6.66.1/schema.json#/resources/aws:iam%2Frole:Role"
- properties:
  - 🟡 "awsProvider" type changed from "/aws/v6.65.0/schema.json#/provider" to "/aws/v6.66.1/schema.json#/provider"
  - 🟡 "clusterSecurityGroup" type changed from "/aws/v6.65.0/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup" to "/aws/v6.66.1/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup"
  - 🟡 "eksCluster" type changed from "/aws/v6.65.0/schema.json#/resources/aws:eks%2Fcluster:Cluster" to "/aws/v6.66.1/schema.json#/resources/aws:eks%2Fcluster:Cluster"
  - 🟡 "eksClusterIngressRule" type changed from "/aws/v6.65.0/schema.json#/resources/aws:ec2%2FsecurityGroupRule:SecurityGroupRule" to "/aws/v6.66.1/schema.json#/resources/aws:ec2%2FsecurityGroupRule:SecurityGroupRule"
  - 🟡 "instanceRoles": items type changed from "/aws/v6.65.0/schema.json#/resources/aws:iam%2Frole:Role" to "/aws/v6.66.1/schema.json#/resources/aws:iam%2Frole:Role"
  - 🟡 "nodeSecurityGroup" type changed from "/aws/v6.65.0/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup" to "/aws/v6.66.1/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup"
🟡 "eks:index:ClusterCreationRoleProvider": properties: "role" type changed from "/aws/v6.65.0/schema.json#/resources/aws:iam%2Frole:Role" to "/aws/v6.66.1/schema.json#/resources/aws:iam%2Frole:Role"
"eks:index:ManagedNodeGroup":
- inputs:
  - 🟡 "launchTemplate" type changed from "/aws/v6.65.0/schema.json#/types/aws:eks%2FNodeGroupLaunchTemplate:NodeGroupLaunchTemplate" to "/aws/v6.66.1/schema.json#/types/aws:eks%2FNodeGroupLaunchTemplate:NodeGroupLaunchTemplate"
  - 🟡 "nodeRole" type changed from "/aws/v6.65.0/schema.json#/resources/aws:iam%2Frole:Role" to "/aws/v6.66.1/schema.json#/resources/aws:iam%2Frole:Role"
  - 🟡 "remoteAccess" type changed from "/aws/v6.65.0/schema.json#/types/aws:eks%2FNodeGroupRemoteAccess:NodeGroupRemoteAccess" to "/aws/v6.66.1/schema.json#/types/aws:eks%2FNodeGroupRemoteAccess:NodeGroupRemoteAccess"
  - 🟡 "scalingConfig" type changed from "/aws/v6.65.0/schema.json#/types/aws:eks%2FNodeGroupScalingConfig:NodeGroupScalingConfig" to "/aws/v6.66.1/schema.json#/types/aws:eks%2FNodeGroupScalingConfig:NodeGroupScalingConfig"
  - 🟡 "taints": items type changed from "/aws/v6.65.0/schema.json#/types/aws:eks%2FNodeGroupTaint:NodeGroupTaint" to "/aws/v6.66.1/schema.json#/types/aws:eks%2FNodeGroupTaint:NodeGroupTaint"
- 🟡 properties: "nodeGroup" type changed from "/aws/v6.65.0/schema.json#/resources/aws:eks%2FnodeGroup:NodeGroup" to "/aws/v6.66.1/schema.json#/resources/aws:eks%2FnodeGroup:NodeGroup"
"eks:index:NodeGroup":
- inputs:
  - 🟡 "clusterIngressRule" type changed from "/aws/v6.65.0/schema.json#/resources/aws:ec2%2FsecurityGroupRule:SecurityGroupRule" to "/aws/v6.66.1/schema.json#/resources/aws:ec2%2FsecurityGroupRule:SecurityGroupRule"
  - 🟡 "extraNodeSecurityGroups": items type changed from "/aws/v6.65.0/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup" to "/aws/v6.66.1/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup"
  - 🟡 "instanceProfile" type changed from "/aws/v6.65.0/schema.json#/resources/aws:iam%2FinstanceProfile:InstanceProfile" to "/aws/v6.66.1/schema.json#/resources/aws:iam%2FinstanceProfile:InstanceProfile"
  - 🟡 "nodeSecurityGroup" type changed from "/aws/v6.65.0/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup" to "/aws/v6.66.1/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup"
- properties:
  - 🟡 "cfnStack" type changed from "/aws/v6.65.0/schema.json#/resources/aws:cloudformation%2Fstack:Stack" to "/aws/v6.66.1/schema.json#/resources/aws:cloudformation%2Fstack:Stack"
  - 🟡 "extraNodeSecurityGroups": items type changed from "/aws/v6.65.0/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup" to "/aws/v6.66.1/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup"
  - 🟡 "nodeSecurityGroup" type changed from "/aws/v6.65.0/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup" to "/aws/v6.66.1/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup"
"eks:index:NodeGroupSecurityGroup":
- inputs:
  - 🟡 "clusterSecurityGroup" type changed from "/aws/v6.65.0/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup" to "/aws/v6.66.1/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup"
  - 🟡 "eksCluster" type changed from "/aws/v6.65.0/schema.json#/resources/aws:eks%2Fcluster:Cluster" to "/aws/v6.66.1/schema.json#/resources/aws:eks%2Fcluster:Cluster"
- properties:
  - 🟡 "securityGroup" type changed from "/aws/v6.65.0/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup" to "/aws/v6.66.1/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup"
  - 🟡 "securityGroupRule" type changed from "/aws/v6.65.0/schema.json#/resources/aws:ec2%2FsecurityGroupRule:SecurityGroupRule" to "/aws/v6.66.1/schema.json#/resources/aws:ec2%2FsecurityGroupRule:SecurityGroupRule"
"eks:index:NodeGroupV2":
- inputs:
  - 🟡 "clusterIngressRule" type changed from "/aws/v6.65.0/schema.json#/resources/aws:ec2%2FsecurityGroupRule:SecurityGroupRule" to "/aws/v6.66.1/schema.json#/resources/aws:ec2%2FsecurityGroupRule:SecurityGroupRule"
  - 🟡 "extraNodeSecurityGroups": items type changed from "/aws/v6.65.0/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup" to "/aws/v6.66.1/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup"
  - 🟡 "instanceProfile" type changed from "/aws/v6.65.0/schema.json#/resources/aws:iam%2FinstanceProfile:InstanceProfile" to "/aws/v6.66.1/schema.json#/resources/aws:iam%2FinstanceProfile:InstanceProfile"
  - 🟡 "launchTemplateTagSpecifications": items type changed from "/aws/v6.65.0/schema.json#/types/aws:ec2%2FLaunchTemplateTagSpecification:LaunchTemplateTagSpecification" to "/aws/v6.66.1/schema.json#/types/aws:ec2%2FLaunchTemplateTagSpecification:LaunchTemplateTagSpecification"
  - 🟡 "nodeSecurityGroup" type changed from "/aws/v6.65.0/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup" to "/aws/v6.66.1/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup"
- properties:
  - 🟡 "autoScalingGroup" type changed from "/aws/v6.65.0/schema.json#/resources/aws:autoscaling%2Fgroup:Group" to "/aws/v6.66.1/schema.json#/resources/aws:autoscaling%2Fgroup:Group"
  - 🟡 "extraNodeSecurityGroups": items type changed from "/aws/v6.65.0/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup" to "/aws/v6.66.1/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup"
  - 🟡 "nodeSecurityGroup" type changed from "/aws/v6.65.0/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup" to "/aws/v6.66.1/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup"

Types

🟡 "eks:index:AccessPolicyAssociation": properties: "accessScope" type changed from "/aws/v6.65.0/schema.json#/types/aws:eks%2FAccessPolicyAssociationAccessScope:AccessPolicyAssociationAccessScope" to "/aws/v6.66.1/schema.json#/types/aws:eks%2FAccessPolicyAssociationAccessScope:AccessPolicyAssociationAccessScope"
"eks:index:ClusterNodeGroupOptions": properties:
- 🟡 "clusterIngressRule" type changed from "/aws/v6.65.0/schema.json#/resources/aws:ec2%2FsecurityGroupRule:SecurityGroupRule" to "/aws/v6.66.1/schema.json#/resources/aws:ec2%2FsecurityGroupRule:SecurityGroupRule"
- 🟡 "extraNodeSecurityGroups": items type changed from "/aws/v6.65.0/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup" to "/aws/v6.66.1/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup"
- 🟡 "instanceProfile" type changed from "/aws/v6.65.0/schema.json#/resources/aws:iam%2FinstanceProfile:InstanceProfile" to "/aws/v6.66.1/schema.json#/resources/aws:iam%2FinstanceProfile:InstanceProfile"
- 🟡 "launchTemplateTagSpecifications": items type changed from "/aws/v6.65.0/schema.json#/types/aws:ec2%2FLaunchTemplateTagSpecification:LaunchTemplateTagSpecification" to "/aws/v6.66.1/schema.json#/types/aws:ec2%2FLaunchTemplateTagSpecification:LaunchTemplateTagSpecification"
- 🟡 "nodeSecurityGroup" type changed from "/aws/v6.65.0/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup" to "/aws/v6.66.1/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup"
"eks:index:CoreData": properties:
- 🟡 "awsProvider" type changed from "/aws/v6.65.0/schema.json#/provider" to "/aws/v6.66.1/schema.json#/provider"
- 🟡 "cluster" type changed from "/aws/v6.65.0/schema.json#/resources/aws:eks%2Fcluster:Cluster" to "/aws/v6.66.1/schema.json#/resources/aws:eks%2Fcluster:Cluster"
- 🟡 "clusterIamRole" type changed from "/aws/v6.65.0/schema.json#/resources/aws:iam%2Frole:Role" to "/aws/v6.66.1/schema.json#/resources/aws:iam%2Frole:Role"
- 🟡 "clusterSecurityGroup" type changed from "/aws/v6.65.0/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup" to "/aws/v6.66.1/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup"
- 🟡 "eksNodeAccess" type changed from "/kubernetes/v4.18.3/schema.json#/resources/kubernetes:core%2Fv1:ConfigMap" to "/kubernetes/v4.19.0/schema.json#/resources/kubernetes:core%2Fv1:ConfigMap"
- 🟡 "encryptionConfig" type changed from "/aws/v6.65.0/schema.json#/types/aws:eks%2FClusterEncryptionConfig:ClusterEncryptionConfig" to "/aws/v6.66.1/schema.json#/types/aws:eks%2FClusterEncryptionConfig:ClusterEncryptionConfig"
- 🟡 "fargateProfile" type changed from "/aws/v6.65.0/schema.json#/resources/aws:eks%2FfargateProfile:FargateProfile" to "/aws/v6.66.1/schema.json#/resources/aws:eks%2FfargateProfile:FargateProfile"
- 🟡 "instanceRoles": items type changed from "/aws/v6.65.0/schema.json#/resources/aws:iam%2Frole:Role" to "/aws/v6.66.1/schema.json#/resources/aws:iam%2Frole:Role"
- 🟡 "oidcProvider" type changed from "/aws/v6.65.0/schema.json#/resources/aws:iam%2FopenIdConnectProvider:OpenIdConnectProvider" to "/aws/v6.66.1/schema.json#/resources/aws:iam%2FopenIdConnectProvider:OpenIdConnectProvider"
- 🟡 "provider" type changed from "/kubernetes/v4.18.3/schema.json#/provider" to "/kubernetes/v4.19.0/schema.json#/provider"
- 🟡 "storageClasses": additional properties type changed from "/kubernetes/v4.18.3/schema.json#/resources/kubernetes:storage.k8s.io%2Fv1:StorageClass" to "/kubernetes/v4.19.0/schema.json#/resources/kubernetes:storage.k8s.io%2Fv1:StorageClass"
"eks:index:CreationRoleProvider": properties:
- 🟡 "provider" type changed from "/aws/v6.65.0/schema.json#/provider" to "/aws/v6.66.1/schema.json#/provider"
- 🟡 "role" type changed from "/aws/v6.65.0/schema.json#/resources/aws:iam%2Frole:Role" to "/aws/v6.66.1/schema.json#/resources/aws:iam%2Frole:Role"
🟡 "eks:index:FargateProfile": properties: "selectors": items type changed from "/aws/v6.65.0/schema.json#/types/aws:eks%2FFargateProfileSelector:FargateProfileSelector" to "/aws/v6.66.1/schema.json#/types/aws:eks%2FFargateProfileSelector:FargateProfileSelector"
"eks:index:NodeGroupData": properties:
- 🟡 "autoScalingGroup" type changed from "/aws/v6.65.0/schema.json#/resources/aws:autoscaling%2Fgroup:Group" to "/aws/v6.66.1/schema.json#/resources/aws:autoscaling%2Fgroup:Group"
- 🟡 "extraNodeSecurityGroups": items type changed from "/aws/v6.65.0/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup" to "/aws/v6.66.1/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup"
- 🟡 "nodeSecurityGroup" type changed from "/aws/v6.65.0/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup" to "/aws/v6.66.1/schema.json#/resources/aws:ec2%2FsecurityGroup:SecurityGroup"
🟡 "eks:index:StorageClass": properties: "metadata" type changed from "/kubernetes/v4.18.3/schema.json#/types/kubernetes:meta%2Fv1:ObjectMeta" to "/kubernetes/v4.19.0/schema.json#/types/kubernetes:meta%2Fv1:ObjectMeta"
No new resources/functions.

t0yv0 · 2024-12-18T20:50:47Z

Looks like some minor breaks in pulumi test are a bit of a problem, looking.

t0yv0 · 2024-12-18T21:26:55Z

nodejs/eks/package.json

@@ -23,8 +23,8 @@
    "bugs": "https://github.com/pulumi/pulumi-eks/issues",
    "dependencies": {
        "@pulumi/aws": "6.65.0",
-        "@pulumi/kubernetes": "4.18.3",
-        "@pulumi/pulumi": "^3.143.0",


Wondering if this will introduce issues similar to pulumi/pulumi-aws-apigateway#178 that necessitates keeping a range or using a special YARN syntax?

pulumi-bot · 2025-01-02T15:25:18Z

This PR has been shipped in release v3.7.0.

t0yv0 mentioned this pull request Dec 18, 2024

Update first-party Pulumi dependencies #1540

Closed

1 task

t0yv0 commented Dec 18, 2024

View reviewed changes

t0yv0 force-pushed the t0yv0/renovate-suggestions branch 2 times, most recently from 8d15f70 to 0c4862e Compare December 20, 2024 16:28

pulumi-renovate bot and others added 2 commits December 23, 2024 20:33

Update first-party Pulumi dependencies

57e4dde

Upgrade to the latest PulumiTest version

e1e6ee6

t0yv0 force-pushed the t0yv0/renovate-suggestions branch from 0c4862e to e1e6ee6 Compare December 23, 2024 20:44

More updates to test code necessitated by lib changes

8235ebe

blampe approved these changes Dec 23, 2024

View reviewed changes

t0yv0 marked this pull request as ready for review December 23, 2024 22:10

t0yv0 merged commit c81c828 into master Dec 23, 2024
36 checks passed

t0yv0 deleted the t0yv0/renovate-suggestions branch December 23, 2024 22:45

mjeffryes assigned t0yv0 Jan 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Accept renovate suggestions #1541

Accept renovate suggestions #1541

t0yv0 commented Dec 18, 2024 •

edited

Loading

github-actions bot commented Dec 18, 2024 •

edited

Loading

t0yv0 commented Dec 18, 2024

t0yv0 Dec 18, 2024

pulumi-bot commented Jan 2, 2025

Accept renovate suggestions #1541

Accept renovate suggestions #1541

Conversation

t0yv0 commented Dec 18, 2024 • edited Loading

github-actions bot commented Dec 18, 2024 • edited Loading

Does the PR have any schema changes?

Resources

Types

t0yv0 commented Dec 18, 2024

t0yv0 Dec 18, 2024

Choose a reason for hiding this comment

pulumi-bot commented Jan 2, 2025

t0yv0 commented Dec 18, 2024 •

edited

Loading

github-actions bot commented Dec 18, 2024 •

edited

Loading