Support for setting init container options and per-pod security groups #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports setting the init container image and DISABLE_TCP_EARLY_DEMUX env var. This allows users to upgrade their version of the CNI, and to support per-pod security groups.
add custom images to cluster example, and reduce line length in disableTcpEarlyDemux description.
Does the PR have any schema changes?Looking good! No breaking changes found. |
viveklak
changed the title
Does the PR have any schema changes?Looking good! No breaking changes found. |
lblackstone
reviewed
Nov 9, 2021
| @@ -50,6 +52,7 @@ function computeVpcCniYaml(cniYamlText: string, args: VpcCniInputs): string { | |||
| // Rewrite the envvars for the CNI daemon set as per the inputs. | |||
| const daemonSet = cniYaml.filter(o => o.kind === "DaemonSet")[0]; | |||
| const env = daemonSet.spec.template.spec.containers[0].env; | |||
| const initEnv = daemonSet.spec.template.spec.initContainers[0].env; | |||
There was a problem hiding this comment.
Are we guaranteed to have at least one initContainer?
There was a problem hiding this comment.
Yes - as per nodejs/eks/cni/aws-k8s-cni.yaml
lblackstone
approved these changes
Nov 9, 2021
flostadler
pushed a commit
that referenced
this pull request
Sep 4, 2024
Support for setting init container options and per-pod security groups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
DISABLE_TCP_EARLY_DEMUX.Builds on top of #617 which seems to be failing on schema validation due to command dispatch workflow (only relevant for external contributions). This adds a test on top of #617 but is otherwise identical.
Related issues (optional)
Fixes #619
Fixes #620
h/t @alex-hunt-materialize
Relates to, but doesn't solve: #622