Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure schema is available in Provider for use in GetSchema calls #660

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Feb 10, 2022

Fixes: #659

We need to take a copy of the schema.json file for use in reading
the file to pass to the Provider for use in GetSchema

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Fixes: #659

We need to take a copy of the schema.json file for use in reading
the file to pass to the Provider for use in GetSchema
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@stack72 stack72 added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Feb 10, 2022
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@stack72 stack72 merged commit 4cfa852 into master Feb 10, 2022
@stack72 stack72 deleted the support-get-schema branch February 10, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The EKS resource provider should return the schema from GetSchema
4 participants