Migrate to v1 of apiextensions for cni yaml #671
Closed
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
jaxxstorm
approved these changes
Mar 28, 2022
|
Really need that one to deploy an EKS 1.22 cluster 👍 |
viveklak
approved these changes
Apr 9, 2022
viveklak
reviewed
Apr 9, 2022
| @@ -185,7 +185,7 @@ spec: | |||
| name: run-dir | |||
|
|
|||
| --- | |||
| apiVersion: apiextensions.k8s.io/v1beta1 | |||
| apiVersion: apiextensions.k8s.io/v1 | |||
| kind: CustomResourceDefinition | |||
| metadata: | |||
| name: eniconfigs.crd.k8s.amazonaws.com | |||
There was a problem hiding this comment.
The test failures suggest you need to define a schema here.. See an example here: https://github.com/argoproj/argo-helm/pull/605/files
There was a problem hiding this comment.
See #683 which includes the latest config from upstream including missing schema from this.
|
Does #680 supersede this? |
|
Closed in favor of #693 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #650