NodeJS warning #2280
NodeJS warning #2280
Conversation
Frassle
force-pushed
the
fraser/nodeWarning
branch
from
f050736 to
ae5eb61
Compare
|
Your site preview for commit ae5eb61 is ready! 🎉 http://pulumi-hugo-origin-pr-2280-ae5eb61d.s3-website.us-west-2.amazonaws.com. |
Frassle
force-pushed
the
fraser/nodeWarning
branch
2 times, most recently
from
51cc823 to
267e300
Compare
|
Your site preview for commit 267e300 is ready! 🎉 http://pulumi-hugo-origin-pr-2280-267e300f.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit 51cc823 is ready! 🎉 http://pulumi-hugo-origin-pr-2280-51cc823b.s3-website.us-west-2.amazonaws.com. |
| @@ -14,6 +14,14 @@ aliases: ["/docs/reference/javascript/"] | |||
|
|
|||
| Pulumi supports writing your infrastructure as code in any JavaScript language running on Node.js using any of the [Current, Active and Maintenance LTS versions](https://nodejs.org/en/about/releases/). | |||
|
|
|||
| {{% notes type="warning" %}} | |||
| Pulumi currently does not support NodeJS 19.2 and higher due to internal V8 changes that our function serialization doesn't currently handle. | |||
There was a problem hiding this comment.
Is it actually true that we don't support it at all, or only that closure serialization does not work on 19.2?
There was a problem hiding this comment.
It's just closure serialisation, but we're not testing against 19.2 untill we can split off all the tests that use closure serialisation from everything else (and it's a lot because so many of the node tests use dynamic providers as part of the tests)
There was a problem hiding this comment.
I wonder if it would help if I flip these sentences around a bit? Say that we expect 19.2 to work except for function serialization, then link the issue, then comment that we're not currently testing 19.2 so we don't consider it fully supported?
There was a problem hiding this comment.
I like that additional bit of nuance to this note - it feels like it re-centers the issue on function serialization and support guarantees re: testing rather than sounding like we don't think people should use 19,2 with Pulumi.
+1
|
@Frassle can we merge this? or is it blocked on something? |
Frassle
force-pushed
the
fraser/nodeWarning
branch
from
267e300 to
7717cdb
Compare
|
I've rephrased the warning, if folk think the new wording is fine then this can be merged. |
|
Your site preview for commit 7717cdb is ready! 🎉 http://pulumi-hugo-origin-pr-2280-7717cdb5.s3-website.us-west-2.amazonaws.com. |
|
Site previews for this pull request have been removed. ✨ |
See pulumi/pulumi#11488