Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if C# DefaultRunner fixes apply to the Java implementation #59

Closed
pawelprazak opened this issue Feb 4, 2022 · 1 comment · Fixed by #60
Closed

Check if C# DefaultRunner fixes apply to the Java implementation #59

pawelprazak opened this issue Feb 4, 2022 · 1 comment · Fixed by #60
Assignees
@t0yv0
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Milestone
0.68

Comments

@pawelprazak
Copy link
Contributor

Hello!

  • Vote on this issue by adding a 👍 reaction
  • To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already)

Issue details

It is not clear if fixes here: pulumi/pulumi@b0f51a6 need to be ported to Java.

Splitting this from #54
@pawelprazak pawelprazak added the kind/bug Some behavior is incorrect or out of spec label Feb 4, 2022
pawelprazak added a commit that referenced this issue Feb 5, 2022
@pawelprazak
Port SDK changes v3.7.0-v3.8.0
b80a26e 
- added InvalidArchive and InvalidAsset
- modify getAllTransitivelyReferencedCustomResourceUrnsAsync into getAllTransitivelyReferencedResourceUrnsAsync
- DefaultRunner enhancements

- IGNORED DefaultRunner fixes from C#, filed as separate issue #59
@pawelprazak pawelprazak mentioned this issue Feb 5, 2022
Merged
3 tasks
@pawelprazak pawelprazak linked a pull request Feb 5, 2022 that will close this issue
Port SDK changes v3.7.0-v3.8.0 #60
Merged
3 tasks
@pawelprazak
Copy link
Contributor Author

I've ported tests that looked relevant, and they pass: https://github.com/pulumi/pulumi-java/blob/b80a26ed8d5b4d36e48e8bd369733485bfe5a492/sdk/jvm/pulumi/src/test/java/io/pulumi/deployment/DeploymentRunnerTest.java

pawelprazak added a commit that referenced this issue Feb 7, 2022
@pawelprazak
Port SDK changes v3.7.0-v3.8.0
a23df90 
- added InvalidArchive and InvalidAsset
- modify getAllTransitivelyReferencedCustomResourceUrnsAsync into getAllTransitivelyReferencedResourceUrnsAsync
- DefaultRunner enhancements

- IGNORED DefaultRunner fixes from C#, filed as separate issue #59
pawelprazak added a commit that referenced this issue Feb 9, 2022
@pawelprazak
Port SDK changes v3.7.0-v3.8.0
300f644 
- added InvalidArchive and InvalidAsset
- modify getAllTransitivelyReferencedCustomResourceUrnsAsync into getAllTransitivelyReferencedResourceUrnsAsync
- DefaultRunner enhancements

- IGNORED DefaultRunner fixes from C#, filed as separate issue #59
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Feb 9, 2022
@mikhailshilkov mikhailshilkov added this to the 0.68 milestone Feb 11, 2022
t0yv0 pushed a commit that referenced this issue May 3, 2022
@pawelprazak @t0yv0
Port SDK changes v3.7.0-v3.8.0
72542ac 
- added InvalidArchive and InvalidAsset
- modify getAllTransitivelyReferencedCustomResourceUrnsAsync into getAllTransitivelyReferencedResourceUrnsAsync
- DefaultRunner enhancements

- IGNORED DefaultRunner fixes from C#, filed as separate issue #59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t0yv0 t0yv0

Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.68
Development

Successfully merging a pull request may close this issue.

Port SDK changes v3.7.0-v3.8.0 pulumi/pulumi-java
4 participants
@pawelprazak @t0yv0 @mikhailshilkov @pulumi-bot