Unskip l2-large-string test
#1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinvp
added
the
impact/no-changelog-required
The `l2-large-string` test emits a resource named `String` which is imported as `com.pulumi.large.String` in the generated program, which then conflicts with the `String` used in the program's `public static void main(String[] args)`. This change avoids the conflict by fully qualifying the built-in Java `String` type when another type named `String` has been imported.
justinvp
force-pushed
the
justin/l2-large-string
branch
from
3906f2e to
3ccaa48
Compare
Zaid-Ajaj
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
l2-large-stringtest emits a resource namedStringwhich is imported ascom.pulumi.large.Stringin the generated program, which then conflicts with theStringused in the program'spublic static void main(String[] args). This change avoids the conflict by fully qualifying the built-in JavaStringtype when another type namedStringhas been imported.