auto: Implementation and initial tests #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds `LocalWorkspace`, `WorkspaceStack`, and `LocalPulumiCommand`, and supporting types, which provides the bulk of the implementation. An initial set of tests is included, but more need to be added. Beyond adding more tests, there are a few known issues that are in-progress (I'm going to open issues for these): - Bug: `NoSummaryEventException` is thrown when running previews on local programs - Bug: `getProjectSettings`/`saveProjectSettings` for YAML only has a bare minimum implementation. It is currently broken for all but the most simple of projects. WIP. - Bug: `getStackSettings`/`saveStackSettings` (de)serialization needs to be fixed. - Bug: Graceful error handling/propagation for inline programs - Engineering: Flesh out the test suite to cover all operations There's also some follow-up fixes / enhancements that we want to consider: - More tests - Bug: Properly pass through `logger` for inline programs (right now, it's not hooked up) - Enhancement: Add support for downloading/installing the CLI via APIs on `LocalPulumiCommand` - Enhancement: Add support for `importResources` (API for `pulumi import`) - Enhancement: Add `RemoteWorkspace` support for running operations using deployments - Enhancement: Avoid serializing inline program invocations. It ended up being simple enough to introduce some locking around this for inline programs, which does allow multiple inline programs to work in the same process. It's just going to serialize them, which could impact folks doing things in parallel. When we have the real fix that avoids the global state, we can remove the lock. I'm sure there are some lingering issues still, so I'll continue to raise PRs with more tests and any bug fixes for issues I find.
justinvp
added
the
impact/no-changelog-required
lunaris
approved these changes
Feb 6, 2025
| /** | ||
| * Base builder for all update options. | ||
| */ | ||
| public static abstract class Builder<B extends Builder<B>> { |
There was a problem hiding this comment.
We don't have to do this pre-go-live but I think we should discuss not doing this when this out the door. I don't think the amount of code saved by inheriting e.g. DestroyOptions from UpdateOptions and the clever Builder inheritance tricks is super worth it. I appreciate that we already do this in e.g. ResourceOptions, though it's a bit messy there and has made certain kinds of changes fiddly in the past.
sdk/java/pulumi/src/main/java/com/pulumi/experimental/automation/LocalWorkspace.java
Outdated
Show resolved
Hide resolved
sdk/java/pulumi/src/main/java/com/pulumi/experimental/automation/LocalWorkspace.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds
LocalWorkspace,WorkspaceStack, andLocalPulumiCommand, and supporting types, which provides the bulk of the implementation. Apologies for the large PR. An initial set of tests is included, but more need to be added.Beyond adding more tests, there are some known issues that I'm currently working on to be done as separate PRs:
Bug:Fixed!NoSummaryEventExceptionis thrown when running previews on local programsgetProjectSettings/saveProjectSettingsYAML (de)serialization #1628getStackSettings/saveStackSettingsYAML (de)serialization #1630com.pulumi.experimental.automationtocom.pulumi.automation#1633There's also some follow-up fixes / enhancements that we want to consider, subsequently:
getProjectSettings/saveProjectSettingsJSON (de)serialization #1629getStackSettings/saveStackSettingsJSON (de)serialization #1631loggerfor inline programs #1636EngineEventobject model and callback design (visitor pattern?) #1635importResources(API forpulumi import) #1638RemoteWorkspacesupport #1639Part of #1607