added examples from pulumiUP #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelprazak
approved these changes
May 4, 2022
| <version>3.15.1</version> | ||
| </dependency> | ||
|
|
||
| <dependency> |
There was a problem hiding this comment.
nit: formatting issue, tabs vs spaces?
| return; | ||
| } | ||
|
|
||
| public interface LambdaArgs { |
There was a problem hiding this comment.
nit: you can add @FunctionalInterface https://docs.oracle.com/javase/8/docs/api/java/lang/FunctionalInterface.html
| * Creates an EKS cluster | ||
| * @param clusterPolicies | ||
| */ | ||
| public EKSStack(List<Policy> clusterPolicies) { |
There was a problem hiding this comment.
nit: could have varargs overload
There was a problem hiding this comment.
true, but who knows what kinds of strange parameters are going to go into this function's constructor
| public class HelloControllerIT { | ||
|
|
||
| @Autowired | ||
| private TestRestTemplate template; |
There was a problem hiding this comment.
I copy pasted this. I'm going to add a readme with attribution
|
|
||
| public class PulumiStack { | ||
|
|
||
| public static void main(String[] args) { |
added link to base project
reverting changes
reverting changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #476
Checklist