Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stack transformations #677

Merged
merged 7 commits into from
Jun 9, 2022
Merged

Add stack transformations #677

merged 7 commits into from
Jun 9, 2022

Conversation

pawelprazak
Copy link
Contributor

@pawelprazak pawelprazak commented Jun 7, 2022 •
edited
Loading

Description

Fixes #478

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@pawelprazak pawelprazak requested a review from t0yv0 June 7, 2022 15:48
@pawelprazak pawelprazak marked this pull request as ready for review June 7, 2022 15:50
pawelprazak
pawelprazak commented Jun 7, 2022
View reviewed changes
sdk/java/pulumi/src/main/java/com/pulumi/deployment/internal/TestOptions.java
public TestOptions(@Nullable String projectName, @Nullable String stackName, boolean preview) {
this.projectName = projectName != null ? projectName : "project";
this.stackName = stackName != null ? stackName : "stack";
this.preview = preview;
this.resourceTransformations = List.of();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to self: make sure to add ability to set this in #553

pawelprazak
pawelprazak commented Jun 7, 2022
View reviewed changes
sdk/java/pulumi/src/main/java/com/pulumi/resources/ResourceTransformation.java
*/
@Deprecated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't wanted to remove this right away since I'm not sure if examples or providers use it (unlikely?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing is OK but needs to be highlighted in CHANGELOG_PENDING to start building the habits. There is no signifiant use yet.

@t0yv0 t0yv0 self-requested a review June 8, 2022 17:08
t0yv0
t0yv0 approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some qns but this is looking perfect - add transformations coverage and new feature on stack transformations with coverage for that also - thank you.

I've only skimmed the tests lmk if you want me to read into those. Looks thorough though.

@pawelprazak
Copy link
Contributor Author

Thank you.

only skimmed the tests lmk if you want me to read into those. Looks thorough though.
No need, they were mostly copied/translated from existing tests.

Should I remove DestroyOnCleanup?

@pawelprazak
Update ResourceTransformation
3315e0d 
- update javadoc
- update getters style
@pawelprazak
Improve StackOptions
1e62844 
- add builder
- adjust getter/setter convention
@pawelprazak
Add an API for StackOptions
14b4156 
- add Pulumi.withOptions
@pawelprazak pawelprazak force-pushed the pprazak/478/stack-transformations-2 branch from 7766bef to e0f9e19 Compare June 9, 2022 13:29
@pawelprazak pawelprazak force-pushed the pprazak/478/stack-transformations-2 branch from e0f9e19 to 8aa73ad Compare June 9, 2022 13:34
@pawelprazak
Copy link
Contributor Author

I've remove copy and DestroyOnCleanup.

pawelprazak
pawelprazak commented Jun 9, 2022
View reviewed changes
sdk/java/pulumi/src/test/java/com/pulumi/resources/StackOptionsTest.java

class StackOptionsTest {

public static Stream<Arguments> testMerge() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a unit test

@pawelprazak
Copy link
Contributor Author

Getting very weird CI errors, but I see them on other builds as well, so does not look related to the PR.

Should I merge?

@t0yv0
Copy link
Member

t0yv0 commented Jun 9, 2022

Let's not merge till we fix main and get green here, which is also failing afaik, let's figure this out.

@t0yv0 t0yv0 merged commit 54c61d2 into main Jun 9, 2022
@pulumi-bot pulumi-bot deleted the pprazak/478/stack-transformations-2 branch June 9, 2022 21:15
@pawelprazak pawelprazak mentioned this pull request Jul 5, 2022
Closed
@myhau myhau mentioned this pull request Aug 4, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t0yv0 t0yv0 t0yv0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support stack transformations
2 participants
@pawelprazak @t0yv0