Custom jumpo type sunset #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelprazak
force-pushed
the
pprazak/390/custom-jumbo-type
branch
from
7229554 to
bd8993c
Compare
Closed
5 tasks
t0yv0
reviewed
Jul 18, 2022
| // optionalAsNull is used in conjunction with the `typeString` parameter | ||
| // `outerOptional` to ensure types line up. | ||
| // In general, `outerOptional` <=> `!optionalAsNull`. | ||
| func emptyTypeInitializer(ctx *classFileContext, t schema.Type, optionalAsNull bool) string { |
There was a problem hiding this comment.
This seems like a win to me! I had doubts this is fully corret in all cases.
t0yv0
reviewed
Jul 18, 2022
| } public CompositePathResponse build() { | ||
| return new CompositePathResponse(order, path); | ||
| } | ||
| public CompositePathResponse build() { |
There was a problem hiding this comment.
Looking good! So this removed the situation with "too many constructors".
Observing that since class fields are no longer final, it's possible to shorten the builder code further by keeping an instance of the class.
@CustomType.Builder
public static final class Builder {
private @Nullable CompositePathResponse $;
}
@CustomType.Setter
public Builder path(@Nullable String path) {
$.path = path;
return this;
}
public CompositePathResponse build() {
return $;
}
There was a problem hiding this comment.
yes, correct, I've noticed it too, just didn't want to make unrelated changes
t0yv0
reviewed
Jul 18, 2022
| @@ -773,6 +773,9 @@ | |||
| }, | |||
| "bar256": { | |||
| "type": "string" | |||
| }, | |||
| "default": { | |||
There was a problem hiding this comment.
Curious why add this one? To test name mangling?
There was a problem hiding this comment.
yes, I wanted to test the default -> default_ and that one or the other will appear in all the correct places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
@CustomType.Builderin codegen.Part of #390
Checklist