Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow failure: build #2857

Closed
pulumi-bot opened this issue Mar 1, 2024 · 0 comments · Fixed by #2858
Closed

Workflow failure: build #2857

pulumi-bot opened this issue Mar 1, 2024 · 0 comments · Fixed by #2858
Assignees
@mjeffryes
Labels
kind/engineering Work that is not visible to an external user p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed

Comments

@pulumi-bot
Copy link
Contributor

Workflow Failure

build has failed. See the list of failures below:
@pulumi-bot pulumi-bot added kind/engineering Work that is not visible to an external user needs-triage Needs attention from the triage team p1 A bug severe enough to be the next item assigned to an engineer labels Mar 1, 2024
@mjeffryes mjeffryes mentioned this issue Mar 1, 2024
Merged
@mjeffryes mjeffryes removed the needs-triage Needs attention from the triage team label Mar 1, 2024
@mjeffryes mjeffryes mentioned this issue Mar 2, 2024
Merged
mjeffryes added a commit that referenced this issue Mar 2, 2024
@mjeffryes
Update version of 'glob' dependency and remove '@types/glob' to resol…
652829a 
…ve imports conflict (#2858)

Pulum 1.108.0 and above introduced introduced a nodejs dependency on the
arborist packaged witch imports a recent version of the "minimatch"
package that exports TS types. We were importing an older version
version of glob that does not provider TS types and using "@types/glob"
for TS types which imports old types for minimatch.

Updating our dependency on glob to one that exports TS types (and thus
does not need the stale @types/glob), resolves the issue.

Fixes #2857
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Mar 2, 2024
mjeffryes added a commit to pulumi/pulumi-aws-native that referenced this issue Mar 5, 2024
@mjeffryes
Remove explicit nodejs dependencies list (#1384)
c335893 
Cleaning up some likely copy-pasta:

While resolving a bug caused by explicit dependencies on old nodejs
packages in pulumi-kubernetes
(pulumi/pulumi-kubernetes#2857), we noticed
that aws-native also has these dependencies, even though it does not
need them because it does not implement any overlay resources.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjeffryes mjeffryes

Labels
kind/engineering Work that is not visible to an external user p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
2 participants
@mjeffryes @pulumi-bot